Use regular (not Perl) grep syntax in scripts #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brian-level looks like https://github.com/openthread/ot-efr32/actions/runs/9514548986/job/26240815333#step:8:176 https://github.com/openthread/ot-efr32/actions/runs/9514548986/job/26240815333#step:8:216 |
lmnotran
reviewed
Jun 14, 2024
lmnotran
reviewed
Jun 14, 2024
lmnotran
suggested changes
Jun 14, 2024
lmnotran
suggested changes
Jun 14, 2024
script/generate
Outdated
| project_name=$(grep -oP 'project_name: \K(.*)' "${slcp}") | ||
| project_line=$(grep 'project_name: ' "${slcp}") | ||
| project_name="${project_line//project_name:/}" | ||
| project_name="${project_line// /}" |
There was a problem hiding this comment.
Suggested change
| project_name="${project_line// /}" | |
| project_name="${project_name// /}" |
https://github.com/openthread/ot-efr32/actions/runs/9521284214/job/26248388553?pr=887#step:8:178
lmnotran
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
LGTM. Thanks @brian-level ! @jwhui please review when you can 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mac platforms are become more locked-down and when grep is installed
by XCode for example it is a BSD version not GNU version so doesn't
have the "-P" option to use perl patterns. This fixes scripts to not
depend on GNU grep.